Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: remove redundant v8 namespaces in env.cc #38792

Closed

Conversation

juanarbol
Copy link
Member

No description provided.

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 24, 2021
@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 24, 2021
@nodejs-github-bot

This comment has been minimized.

src/env.cc Outdated Show resolved Hide resolved
src/env.cc Outdated Show resolved Hide resolved
@juanarbol juanarbol force-pushed the juan/remove-redundant-namespaces branch from 641cf9b to 7025d23 Compare May 25, 2021 19:49
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 25, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/38328/ 💚

@jasnell jasnell removed the needs-ci PRs that need a full CI run. label May 25, 2021
juanarbol added a commit that referenced this pull request May 26, 2021
PR-URL: #38792
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@juanarbol
Copy link
Member Author

Landed in d398712

@juanarbol juanarbol closed this May 26, 2021
danielleadams pushed a commit that referenced this pull request May 31, 2021
PR-URL: #38792
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@danielleadams danielleadams mentioned this pull request May 31, 2021
@richardlau
Copy link
Member

Depends on #32984

@juanarbol juanarbol deleted the juan/remove-redundant-namespaces branch August 26, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.