Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: initialize _questionCallback during construction #38796

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

readline: initialize _questionCallback during construction #38796

wants to merge 1 commit into from

Conversation

Ayase-252
Copy link
Member

_questionCallback is used in Interface, but it is not initialized in constrctor.

This PR makes _questionCallback initialized properly to improve the readability.

@github-actions github-actions bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels May 24, 2021
@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ayase-252 @VoltrexKeyva @aduh95