doc: remove references to deleted freenode channels #39047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc
ronag
approved these changes
Jun 15, 2021
mmarchini
approved these changes
Jun 15, 2021
tniessen
approved these changes
Jun 15, 2021
cjihrig
approved these changes
Jun 16, 2021
benjamingr
approved these changes
Jun 16, 2021
lpinca
approved these changes
Jun 16, 2021
joyeecheung
approved these changes
Jun 16, 2021
joesepi
approved these changes
Jun 16, 2021
|
I'd propose a fast track for this |
benjamingr
added
the
fast-track
|
Fast-track has been requested by @benjamingr. Please 👍 to approve. |
|
If this lands, I’d assume nodejs/nodejs.org#3923 or some variant should also probably land too. |
Lxxyx
approved these changes
Jun 17, 2021
XadillaX
approved these changes
Jun 17, 2021
gengjiawen
approved these changes
Jun 17, 2021
gengjiawen
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/39047 ✔ Done loading data for nodejs/node/pull/39047 ----------------------------------- PR info ------------------------------------ Title doc: remove references to deleted freenode channels (#39047) Author devsnek (@devsnek) Branch devsnek:rip-freenode -> nodejs:master Labels doc, fast-track, meta Commits 1 - doc: remove references to deleted freenode channels Committers 1 - Gus Caplan PR-URL: https://github.com/nodejs/node/pull/39047 Reviewed-By: Robert Nagy Reviewed-By: Mary Marchini Reviewed-By: Matteo Collina Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Joyee Cheung Reviewed-By: Michael Dawson Reviewed-By: Zijian Liu Reviewed-By: Khaidi Chu Reviewed-By: Jiawen Geng ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39047 Reviewed-By: Robert Nagy Reviewed-By: Mary Marchini Reviewed-By: Matteo Collina Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Joyee Cheung Reviewed-By: Michael Dawson Reviewed-By: Zijian Liu Reviewed-By: Khaidi Chu Reviewed-By: Jiawen Geng -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 15 Jun 2021 20:38:28 GMT ✔ Approvals: 12 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684466041 ✔ - Mary Marchini (@mmarchini) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684480431 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684510273 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684531260 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684663596 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/39047#pullrequestreview-685131502 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39047#pullrequestreview-685141388 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-685361956 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-685544629 ✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/39047#pullrequestreview-685813419 ✔ - Khaidi Chu (@XadillaX): https://github.com/nodejs/node/pull/39047#pullrequestreview-685829599 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/39047#pullrequestreview-686087441 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/945925856 |
github-actions
bot
added
the
commit-queue-failed
PR-URL: #39047 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
landed in e3ba960 |
joyeecheung
pushed a commit
to joyeecheung/node
that referenced
this pull request
Jun 17, 2021
PR-URL: nodejs#39047 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 21, 2021
PR-URL: #39047 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
PR-URL: #39047 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
PR-URL: #39047 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
targos
removed
the
commit-queue-failed
foxxyz
pushed a commit
to foxxyz/node
that referenced
this pull request
Oct 18, 2021
PR-URL: nodejs#39047 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs nodejs/TSC#1031
cc @nodejs/tsc @nodejs/build