Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: duplexify #39519

Closed
wants to merge 18 commits into from
Closed

stream: duplexify #39519

wants to merge 18 commits into from

Conversation

@ronag
Copy link
Member

@ronag ronag commented Jul 25, 2021

  • Introduce Duplex.from.
  • Move out makeDuplex from compose.
  • Add support for { readable, writable } pairs and Promise.
  • Add support for web streams in compose, pipeline and finished.
@ronag ronag requested a review from mcollina Jul 25, 2021
@ronag ronag added the stream label Jul 25, 2021
@ronag
Copy link
Member Author

@ronag ronag commented Jul 25, 2021

@ronag ronag force-pushed the duplexify branch 4 times, most recently from f2b9ae6 to 7904fb0 Jul 25, 2021
lib/internal/streams/duplexify.js Outdated Show resolved Hide resolved
lib/stream.js Outdated Show resolved Hide resolved
@ronag ronag force-pushed the duplexify branch 5 times, most recently from 0bbf146 to 5a8110f Jul 26, 2021
@ronag ronag requested review from aduh95 and mcollina Jul 26, 2021
@ronag ronag added request-ci and removed needs-ci labels Jul 26, 2021
Copy link

@natalaglenn7 natalaglenn7 left a comment

.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jul 26, 2021

@ronag ronag force-pushed the duplexify branch 7 times, most recently from dd724f6 to ce3b597 Jul 26, 2021
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Aug 3, 2021

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Aug 3, 2021

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Aug 3, 2021

ronag added a commit that referenced this issue Aug 3, 2021
PR-URL: #39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ronag
Copy link
Member Author

@ronag ronag commented Aug 3, 2021

Landed in 533cafc

@danielleadams
Copy link
Member

@danielleadams danielleadams commented Aug 15, 2021

@ronag Do you mind backporting this to v16.x-staging? It does not land cleanly into the branch. Thanks!

@ronag ronag self-assigned this Aug 16, 2021
ronag added a commit to nxtedition/node that referenced this issue Aug 20, 2021
PR-URL: nodejs#39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
ronag added a commit to nxtedition/node that referenced this issue Aug 20, 2021
PR-URL: nodejs#39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <ckbenjamingr@gmail.com>
Backport-PR-URL: nodejs#39820
@ronag
Copy link
Member Author

@ronag ronag commented Aug 20, 2021

ronag added a commit to nxtedition/node that referenced this issue Aug 23, 2021
PR-URL: nodejs#39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <ckbenjamingr@gmail.com>
Backport-PR-URL: nodejs#39820
targos added a commit that referenced this issue Aug 23, 2021
PR-URL: #39519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <ckbenjamingr@gmail.com>
Backport-PR-URL: #39820
targos added a commit that referenced this issue Aug 25, 2021
Notable changes:

doc:
  * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) #38906
stream:
  * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) #39519
  * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) #39628
util:
  * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) #39814

PR-URL: #39875
targos added a commit that referenced this issue Aug 25, 2021
Notable changes:

doc:
  * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) #38906
stream:
  * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) #39519
  * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) #39628
util:
  * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) #39814

PR-URL: #39875
wwwzbwcom added a commit to wwwzbwcom/node that referenced this issue Aug 26, 2021
Notable changes:

doc:
  * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) nodejs#38906
stream:
  * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) nodejs#39519
  * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) nodejs#39628
util:
  * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) nodejs#39814

PR-URL: nodejs#39875
codebytere added a commit to electron/electron that referenced this issue Aug 30, 2021
jkleinsc pushed a commit to electron/electron that referenced this issue Aug 31, 2021
* chore: bump node in DEPS to v16.8.0

* build: add option to hide console window

nodejs/node#39712

* chore: fixup patch indices

* stream: duplexify

nodejs/node#39519

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants