Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix ERR_REQUIRE_ESM error for null frames #39593

Closed
wants to merge 1 commit into from
Closed

module: fix ERR_REQUIRE_ESM error for null frames #39593

wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

Fixes a bug where ERR_REQUIRE_ESM would throw a endsWith error for string when checking null error frames as reported in e2a6399#commitcomment-54198959.

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Jul 30, 2021
@guybedford
Copy link
Contributor Author

Requesting a fast track on this fix as well, please upvote this comment. //cc @nodejs/modules

guybedford referenced this pull request Jul 30, 2021
@guybedford
esm: refine ERR_REQUIRE_ESM errors
e2a6399 
PR-URL: #39175
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39370/

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 30, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39373/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2021
@github-actions
Copy link
Contributor

Landed in 46e6c64...b0a6ade

@github-actions github-actions bot closed this Jul 31, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 31, 2021
@guybedford @nodejs-github-bot
module: fix ERR_REQUIRE_ESM error for null frames
b0a6ade 
PR-URL: #39593
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@olizilla olizilla mentioned this pull request Jul 31, 2021
Closed
@zeripath zeripath mentioned this pull request Aug 1, 2021
Merged
@targos targos mentioned this pull request Aug 1, 2021
Open
@adalinesimonian adalinesimonian mentioned this pull request Aug 1, 2021
Closed
targos pushed a commit that referenced this pull request Aug 2, 2021
@guybedford @targos
module: fix ERR_REQUIRE_ESM error for null frames
a627d7b 
PR-URL: #39593
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@nstepien nstepien mentioned this pull request Aug 2, 2021
Merged
@silverwind
Copy link
Contributor

This broke quite a few things like webpack and eslint, it would be good to have a 16.6.1 release with this fix included.

@targos
Copy link
Member

targos commented Aug 2, 2021

I'm preparing a release for tomorrow.

targos pushed a commit that referenced this pull request Aug 2, 2021
@guybedford @targos
module: fix ERR_REQUIRE_ESM error for null frames
93bbaa0 
PR-URL: #39593
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Aug 2, 2021
@targos
2021-08-03, Version 16.6.1 (Current)
3d53ff8 
Notable changes:

* Updated npm to 7.20.3 (npm team)
  #39579
* Reverted an ABI-breaking change from V8 9.2 that could impact some
  native modules (Michaël Zasso)
  #39624
* Fixed a bug in error handling known to affect at least Webpack and
  Jest (Guy Bedford) #39593

PR-URL: #39631
@targos targos mentioned this pull request Aug 2, 2021
Merged
targos added a commit that referenced this pull request Aug 3, 2021
@targos
2021-08-03, Version 16.6.1 (Current)
51cd4a8 
Notable changes:

* Updated npm to 7.20.3 (npm team)
  #39579
* Reverted an ABI-breaking change from V8 9.2 that could impact some
  native modules (Michaël Zasso)
  #39624
* Fixed a bug in error handling known to affect at least Webpack and
  Jest (Guy Bedford) #39593

PR-URL: #39631
@gh640 gh640 mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeck bmeck bmeck approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@guybedford @nodejs-github-bot @silverwind @targos @bmeck @Trott