-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v16.6.1 release proposal #39631
Merged
Merged
v16.6.1 release proposal #39631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #39507 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #39492 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #39453 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #39465 Fixes: #39408 Fixes: #39456 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #39593 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
For every object that inherits from `Object.prototype`, the REPL includes the `Object.prototype` methods in its autocompletion. This is already a little noisy, but in particular, this also includes the legacy `__defineGetter__` family of methods; since those are deprecated and not in practical use anymore, it helps reduce noise a bit to remove them. This commit does not remove `__proto__` as it is a little more popular and, despite its downsides, a slightly more convenient way to access the prototype of an object in the REPL than `Object.getPrototypeOf(...)`. PR-URL: #39576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: v8/v8@a7980d4 Refs: v8/v8@ad4eab0 Fixes: #39623 PR-URL: #39624 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve. |
/cc @nodejs/releasers |
guybedford
approved these changes
Aug 2, 2021
BethGriggs
approved these changes
Aug 2, 2021
gengjiawen
approved these changes
Aug 3, 2021
targos
added a commit
to targos/nodejs.org
that referenced
this pull request
Aug 3, 2021
targos
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-08-03, Version 16.6.1 (Current), @targos
Notable Changes
Commits
6c769ccedf
] - build: override python executable path on configure (legendecas) #39465cbf6a01c17
] - crypto: fixgenerateKeyPair
with encoding 'jwk' (himself65) #393193091295609
] - deps: revert ABI-breaking change from V8 9.2 (Michaël Zasso) #3962406d7b8e8c8
] - deps: upgrade npm to 7.20.3 (npm team) #395797b612fadc2
] - doc: fix crypto.hkdf callback derivedKey type (Filip Skokan) #394537a731efd97
] - doc,lib,test: rename HKDF 'key' argument (Tobias Nießen) #3947493bbaa0ce9
] - module: fix ERR_REQUIRE_ESM error for null frames (Guy Bedford) #39593e13162de09
] - module: refineenrichCJSError
(Antoine du Hamel) #39507815fbec6f1
] - repl: do not include legacy getter/setter methods in completion (Anna Henningsen) #395760405c8d3f0
] - zlib: avoid convertingUint8Array
instances toBuffer
(Antoine du Hamel) #39492