lib: make structuredClone spec compliant

[VoltrexKeyva]

Fixes: #40246

[targos]

It would be nice to have a WPT for this.

[targos]

BTW, I'm not sure we should throw an error, but instead just grab transfer from the passed object and create a new options object with it.

[VoltrexKeyva]

BTW, I'm not sure we should throw an error, but instead just grab transfer from the passed object and create a new options object with it.

We mostly just throw an error if the passed value is not spec complaint in most cases, throwing an error here would be nice for keeping consistency unless there's a special case where we have to avoid throwing an error.

[targos]

What's important here is not consistency, but spec compliance. The spec just asks to pass options["transfer"]. Maybe I'm wrong, but I understand that it should not be an error to do this:

const options = [];
options.transfer = [toTransfer];
structuredClone({}, options);

[targos]

Do we have a WHATWG spec specialist that we could ping to take a look?

[aduh95]

Maybe @surma would be available to review this, since they are the one who proposed this API to WHATWG.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/40142/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/40144/

[github-actions]

Landed in 6199441...3d11baf