Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typo in stream docs, replace objectModel to objectMode #40337

Closed
wants to merge 1 commit into from
Closed

docs: fix typo in stream docs, replace objectModel to objectMode #40337

wants to merge 1 commit into from

Conversation

juanarbol
Copy link
Member

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Oct 5, 2021
@HarshithaKP HarshithaKP added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Fast-track has been requested by @HarshithaKP. Please 👍 to approve.

@HarshithaKP HarshithaKP added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 6, 2021
@Lxxyx Lxxyx added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Landed in 28f711b...87da53c

@github-actions github-actions bot closed this Oct 6, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 6, 2021
@juanarbol @nodejs-github-bot
doc: fix typo in stream docs
87da53c 
PR-URL: #40337
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 7, 2021
@juanarbol @danielleadams
doc: fix typo in stream docs
1db2ffd 
PR-URL: #40337
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 7, 2021
Merged
@lpinca lpinca added dont-land-on-v12.x dont-land-on-v16.x PRs that should not land on the v16.x-staging branch and should not be released in v16.x. labels Nov 15, 2021
@lpinca lpinca mentioned this pull request Nov 16, 2021
Closed
@juanarbol juanarbol deleted the juan/fix-typo-docs branch October 24, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v16.x PRs that should not land on the v16.x-staging branch and should not be released in v16.x. fast-track PRs that do not need to wait for 48 hours to land. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@juanarbol @benjamingr @Lxxyx @HarshithaKP @lpinca @nodejs-github-bot