Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct esm spec package scope lookup definition #40592

Closed
wants to merge 1 commit into from
Closed

doc: correct esm spec package scope lookup definition #40592

wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Oct 24, 2021 •
edited by aduh95
Loading

This corrects the logic in the READ_PACKAGE_SCOPE method where it was returning the parsed package.json contents instead of the URL followed by a second read phase. In the process READ_PACKAGE_SCOPE has been renamed to LOOKUP_PACKAGE_SCOPE to more clearly reflect the definition of this return value.

Fixes: #40578

@nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Oct 24, 2021
@guybedford guybedford mentioned this pull request Oct 24, 2021
Closed
1 task
@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 25, 2021
@guybedford
Copy link
Contributor Author

Landed in 687debb.

@guybedford guybedford closed this Oct 26, 2021
@guybedford guybedford deleted the spec-scope-fix branch October 26, 2021 23:03
guybedford added a commit that referenced this pull request Oct 26, 2021
@guybedford
doc: correct esm spec scope lookup definition
687debb 
PR-URL: #40592
Fixes: #40578
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
targos pushed a commit that referenced this pull request Nov 6, 2021
@guybedford @targos
doc: correct esm spec scope lookup definition
6ae134e 
PR-URL: #40592
Fixes: #40578
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targos targos mentioned this pull request Nov 8, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 29, 2022
@guybedford @danielleadams
doc: correct esm spec scope lookup definition
5c90975 
PR-URL: #40592
Fixes: #40578
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@targos targos targos approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: READ_PACKAGE_SCOPE returns JSON not a URL
6 participants
@guybedford @GeoffreyBooth @targos @aduh95 @nodejs-github-bot @Mesteery