Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix tools.yml errors #40870

Merged
merged 1 commit into from
Nov 19, 2021
Merged

build: fix tools.yml errors #40870

merged 1 commit into from
Nov 19, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 19, 2021

No description provided.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 19, 2021
@Trott
Copy link
Member Author

Trott commented Nov 19, 2021

Refs: https://github.com/nodejs/node/runs/4195785114?check_suite_focus=true

@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 19, 2021
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2021
@nodejs-github-bot nodejs-github-bot merged commit e0233fc into nodejs:master Nov 19, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in e0233fc

@Trott Trott deleted the tools.yml branch November 19, 2021 13:44
targos pushed a commit that referenced this pull request Nov 21, 2021
@Trott @targos
build: fix tools.yml errors
e793331 
PR-URL: #40870
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@Trott @danielleadams
build: fix tools.yml errors
c199fa7 
PR-URL: #40870
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
build: fix tools.yml errors
323c058 
PR-URL: #40870
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@aduh95 aduh95 aduh95 approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Trott @nodejs-github-bot @lpinca @targos @aduh95 @VoltrexKeyva