Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix consistency of methods that emit warnings #41249

Merged
merged 1 commit into from
Jan 21, 2022
Merged

lib: fix consistency of methods that emit warnings #41249

merged 1 commit into from
Jan 21, 2022

Conversation

kuriyosh
Copy link
Contributor

@kuriyosh kuriyosh commented Dec 20, 2021 •
edited
Loading

For consistency, I refactored emitInvalidHostnameWarning method same logic as emitTypeCoercionDeprecationWarning.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels Dec 20, 2021
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41623/

@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 17, 2022
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42000/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit feafea1 into nodejs:master Jan 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in feafea1

BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@kuriyosh @BethGriggs
lib: fix consistency of methods that emit warnings
306dd1c 
PR-URL: #41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@kuriyosh @Linkgoron
lib: fix consistency of methods that emit warnings
eadb217 
PR-URL: nodejs#41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@kuriyosh @danielleadams
lib: fix consistency of methods that emit warnings
13a3faa 
PR-URL: #41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@kuriyosh @danielleadams
lib: fix consistency of methods that emit warnings
fc7c831 
PR-URL: #41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@kuriyosh @danielleadams
lib: fix consistency of methods that emit warnings
9feab92 
PR-URL: #41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@kuriyosh @danielleadams
lib: fix consistency of methods that emit warnings
0f3287d 
PR-URL: #41249
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@watilde watilde watilde approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kuriyosh @nodejs-github-bot @jasnell @watilde @Mesteery @aduh95