Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: disable max-len ESLint rule for strings #41536

Closed
wants to merge 1 commit into from
Closed

tools: disable max-len ESLint rule for strings #41536

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 15, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Jan 15, 2022
@Trott Trott mentioned this pull request Jan 15, 2022
Closed
@VoltrexKeyva VoltrexKeyva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jan 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 15, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41904/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41929/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41966/

jasnell
jasnell requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have more discussion on this. I'm not a fan of removing max line lengths. I'm happy to increase the current limits but not so much removing them entirely. I know this PR is limiting that change to just strings but still, I'd like more discussion around this first.

@github-actions github-actions bot mentioned this pull request Jan 18, 2022
Open
16 tasks
@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2022
@github-actions github-actions bot mentioned this pull request Jan 19, 2022
Open
13 tasks
@tniessen
Copy link
Member

Alternative: #41509
Alternative: #41586

@tniessen tniessen mentioned this pull request Jan 19, 2022
Merged
mcollina
mcollina approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Trott
Copy link
Member Author

Trott commented Jan 19, 2022

I'm happy to increase the current limits but not so much removing them entirely.

#41586

@targos
Copy link
Member

targos commented Jan 24, 2022

I'm still in favor of this change after #41586

@Trott Trott closed this Apr 6, 2022
@Trott Trott deleted the eslint-max-len-strings branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell requested changes

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@himself65 himself65 himself65 approved these changes

@Mesteery Mesteery Mesteery approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet