Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: improve the coverage of the validator #42443

Merged
merged 3 commits into from Apr 2, 2022
Merged

lib: improve the coverage of the validator #42443

merged 3 commits into from Apr 2, 2022

Conversation

mawaregetsuka
Copy link
Contributor

In current version, if you take symbol or bigint as arguments to the validator, a native error will be thrown.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 23, 2022
BridgeAR
BridgeAR requested changes Mar 23, 2022
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Please just move the typeof value !== 'number' check instead of adding additional ones. That would already cover the situation.
In addition, please add a test that verifies that the correct error is thrown.

@mawaregetsuka
Copy link
Contributor Author

@BridgeAR
Thanks for your suggestion, I've made improvements.

VoltrexKeyva
VoltrexKeyva approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@VoltrexKeyva VoltrexKeyva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aduh95
aduh95 approved these changes Mar 24, 2022
View reviewed changes
test/parallel/test-validators.js Outdated

// validateInt32() and validateUint32()
[
Symbol(), 1n, {}, [], false, true, undefined, null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Symbol(), 1n, {}, [], false, true, undefined, null,
Symbol(), 1n, {}, [], false, true, undefined, null, () => {}, '', '1',

test/parallel/test-validators.js Outdated
code: 'ERR_OUT_OF_RANGE'
}));
[
Symbol(), 1n, {}, [], false, true, undefined, null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Symbol(), 1n, {}, [], false, true, undefined, null,
Symbol(), 1n, {}, [], false, true, undefined, null, () => {}, '', '1',

test/parallel/test-validators.js
4294967296, -1, NaN,
].forEach((val) => assert.throws(() => validateUint32(val, 'name'), {
code: 'ERR_OUT_OF_RANGE'
}));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}));
}));
// Ensure it doesn't throw on acceptable values:
validateInt32(0, 'name');
validateUint32(0, 'name');
validateInt32(1, 'name');
validateUint32(1, 'name');
validateInt32(-1, 'name');

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 25, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43185/

@github-actions github-actions bot mentioned this pull request Mar 27, 2022
Open
26 tasks
@mawaregetsuka
Copy link
Contributor Author

It looks like CI is having some problems with centos7-arm64-gcc8,ubuntu1804-arm64,ubuntu2004-arm64.
How can we solve this problem?
Please let me know if there's anything I can do.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43199/

This was referenced Mar 28, 2022
Open
Open
Open
Open
Open
Open
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit 302fd02 into nodejs:master Apr 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 302fd02

@github-actions github-actions bot mentioned this pull request Apr 3, 2022
Open
8 tasks
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@mawaregetsuka @juanarbol
lib: improve the coverage of the validator
3ee5434 
PR-URL: nodejs#42443
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 5, 2022
Closed
Merged
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@mawaregetsuka @juanarbol
lib: improve the coverage of the validator
3bac969 
PR-URL: #42443
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@mawaregetsuka @xtx1130
lib: improve the coverage of the validator
2341cd9 
PR-URL: nodejs#42443
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@mawaregetsuka @juanarbol
lib: improve the coverage of the validator
7127c3c 
PR-URL: #42443
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@mawaregetsuka @danielleadams
lib: improve the coverage of the validator
b332abb 
PR-URL: #42443
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@mawaregetsuka @targos
lib: improve the coverage of the validator
c97f74c 
PR-URL: #42443
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@mawaregetsuka @targos
lib: improve the coverage of the validator
58f80b0 
PR-URL: #42443
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@mawaregetsuka @guangwong
lib: improve the coverage of the validator
f8d29a1 
PR-URL: nodejs/node#42443
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@aduh95 aduh95 aduh95 approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mawaregetsuka @nodejs-github-bot @jasnell @lpinca @BridgeAR @aduh95 @VoltrexKeyva