-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: delete test/pummel/test-repl-empty-maybelocal-crash.js
#42720
test: delete test/pummel/test-repl-empty-maybelocal-crash.js
#42720
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
c06b845
to
e0091c7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's a memory issue (and it doesn't only affect FreeBSD), we should probably use common.enoughTestMem
This comment was marked as outdated.
This comment was marked as outdated.
@targos that doesn't seem to work - https://ci.nodejs.org/job/node-test-commit-freebsd/43653/nodes=freebsd12-x64/console. :/ |
Or maybe just delete the test? |
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: nodejs#42719 Signed-off-by: Darshan Sen <raisinten@gmail.com>
fc18ad6
to
d56a3bc
Compare
test-repl-empty-maybelocal-crash
flaky on freebsdtest/pummel/test-repl-empty-maybelocal-crash.js
Agreed, @targos deleted, PTAL |
I don't know if it's possible, but if we were able to reduce the maximum buffer size limit with a command-line flag, that could be another way to fix it. |
That won't be possible because Node.js uses Line 32 in 93c4dc5
for the max buffer length and it's a compile time constant from V8 node/deps/v8/include/v8-typed-array.h Lines 25 to 28 in 93c4dc5
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
The flake that keeps appearing is #42741. I've resumed CI again, but considering the contents of this PR is removing a different test - I propose landing this as-is. I'm hoping to include this PR in v18.0.0 to mitigate some of CI instability. |
Hit the flake again, but FreeBSD is also experimental. Landing this now. |
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: #42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42720 Fixes: #42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Landed in 19064be |
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: nodejs#42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42720 Fixes: nodejs#42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: nodejs#42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42720 Fixes: nodejs#42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: nodejs#42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42720 Fixes: nodejs#42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: #42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42720 Fixes: #42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: #42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42720 Backport-PR-URL: #42967 Fixes: #42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: #42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42720 Backport-PR-URL: #42967 Fixes: #42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
It was disconnecting the runners from the CI server. Not worth having a
resource-intensive test for this kind of an edge cases.
Fixes: #42719
Signed-off-by: Darshan Sen raisinten@gmail.com