test: improve lib/internal/test_runner/test.js coverage #42745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Apr 15, 2022
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Apr 15, 2022
|
@cjihrig Thanks, I resolved conflicts. |
16 tasks
cjihrig
reviewed
Apr 16, 2022
test/message/test_runner_output.out
Outdated
| duration_ms: * | ||
| failureType: 'testCodeFailure' | ||
| error: 'thrown from subtest sync throw fails at first' | ||
| code: ERR_TEST_FAILURE |
There was a problem hiding this comment.
Oh, I think the code fields here and below need to be in quotes now. The CI is probably going to fail because of it.
There was a problem hiding this comment.
@cjihrig Oops, I overlooked it. I changed to wrapping error code in single quotes. Thanks again.
aduh95
added
request-ci
|
@fossamagna can you please rebase on top of |
lpinca
approved these changes
Apr 16, 2022
|
There is a typo in the first commit message: "coveage" -> coverage". |
|
@aduh95 Sorry. I will rebase top of |
fossamagna
changed the title
fossamagna
force-pushed
the
test-test-runner-coverage
branch
from
330f986
to
e9da7bf
Compare
15 tasks
|
@fossamagna you can force push on this PR branch. |
|
@lpinca Thanks, I rebase and force push. |
github-actions
bot
removed
the
request-ci
14 tasks
16 tasks
marsonya
approved these changes
Apr 19, 2022
16 tasks
jasnell
approved these changes
Apr 20, 2022
22 tasks
This was referenced Apr 22, 2022
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 8cbc390 |
targos
pushed a commit
that referenced
this pull request
Apr 28, 2022
PR-URL: #42745 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Sadly, this is part of the built-in test-runner, which is not landed in v16.x |
aduh95
pushed a commit
to aduh95/node-core-test
that referenced
this pull request
Jul 8, 2022
PR-URL: nodejs/node#42745 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
to aduh95/node-core-test
that referenced
this pull request
Jul 9, 2022
PR-URL: nodejs/node#42745 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
to aduh95/node-core-test
that referenced
this pull request
Jul 9, 2022
PR-URL: nodejs/node#42745 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42745 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42745 Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a test coverage in
lib/internal/test_runner/test.jscoveageRef: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371
This validates that printing correctly error message when multiple subtests failed