build: clarify missing clang-format tool #42762

tniessen · 2022-04-17T11:36:45Z

This confused me when I had to run make format-cpp. Clarify that it's not clang-format itself that's missing but rather some tooling around that.

github-actions · 2022-04-17T11:38:47Z

Fast-track has been requested by @tniessen. Please 👍 to approve.

Makefile

Co-authored-by: Rich Trott <rtrott@gmail.com>

nodejs-github-bot · 2022-04-18T09:37:31Z

Commit Queue failed

- Loading data for nodejs/node/pull/42762
✔  Done loading data for nodejs/node/pull/42762
----------------------------------- PR info ------------------------------------
Title      build: clarify missing clang-format tool (#42762)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:makefile-clang-format-is-not-clang-format -> nodejs:master
Labels     build, fast-track
Commits    1
 - build: clarify missing clang-format tool
Committers 1
 - Tobias Nießen 
PR-URL: https://github.com/nodejs/node/pull/42762
Reviewed-By: Darshan Sen 
Reviewed-By: Rich Trott 
Reviewed-By: Mestery 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42762
Reviewed-By: Darshan Sen 
Reviewed-By: Rich Trott 
Reviewed-By: Mestery 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 17 Apr 2022 11:36:45 GMT
   ✔  Approvals: 4
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943939663
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943954938
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42762#pullrequestreview-943982857
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42762#pullrequestreview-944122927
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2183248078

tniessen · 2022-04-18T09:45:29Z

I fell for nodejs/TSC#1044, thinking needs-ci affects tooling...

nodejs-github-bot · 2022-04-18T09:45:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43551/

nodejs-github-bot · 2022-04-18T12:27:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43553/

nodejs-github-bot · 2022-04-18T14:09:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43555/

nodejs-github-bot · 2022-04-18T16:32:13Z

Commit Queue failed

- Loading data for nodejs/node/pull/42762 ✔ Done loading data for nodejs/node/pull/42762 ----------------------------------- PR info ------------------------------------ Title build: clarify missing clang-format tool (#42762) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:makefile-clang-format-is-not-clang-format -> nodejs:master Labels build, fast-track Commits 1 - build: clarify missing clang-format tool Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/42762 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42762 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 17 Apr 2022 11:36:45 GMT ✔ Approvals: 4 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943939663 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943954938 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42762#pullrequestreview-943982857 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42762#pullrequestreview-944122927 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-04-18T14:09:36Z: https://ci.nodejs.org/job/node-test-pull-request/43555/ - Querying data for job/node-test-pull-request/43555/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42762 From https://github.com/nodejs/node * branch refs/pull/42762/merge -> FETCH_HEAD ✔ Fetched commits as 3347361713b4..88b6f6a0806b -------------------------------------------------------------------------------- [master fdfefcdcfc] build: clarify missing clang-format tool Author: Tobias Nießen Date: Sun Apr 17 13:34:31 2022 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- build: clarify missing clang-format tool

Co-authored-by: Rich Trott rtrott@gmail.com

PR-URL: #42762
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[master 76bd049cad] build: clarify missing clang-format tool
Author: Tobias Nießen tniessen@tnie.de
Date: Sun Apr 17 13:34:31 2022 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
✖ 76bd049cadc668d99ea5cc64ae5b0e4a50305032
✖ 1:0 Co-authored-by must be a trailer co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 3:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/2184865680

nodejs-github-bot · 2022-04-21T04:29:23Z

Commit Queue failed

- Loading data for nodejs/node/pull/42762 ✔ Done loading data for nodejs/node/pull/42762 ----------------------------------- PR info ------------------------------------ Title build: clarify missing clang-format tool (#42762) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:makefile-clang-format-is-not-clang-format -> nodejs:master Labels build, needs-ci Commits 1 - build: clarify missing clang-format tool Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/42762 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42762 Reviewed-By: Darshan Sen Reviewed-By: Rich Trott Reviewed-By: Mestery Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 17 Apr 2022 11:36:45 GMT ✔ Approvals: 5 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943939663 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-943954938 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42762#pullrequestreview-943982857 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42762#pullrequestreview-944122927 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42762#pullrequestreview-947806244 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-04-18T16:32:13Z: https://ci.nodejs.org/job/node-test-pull-request/43555/ - Querying data for job/node-test-pull-request/43555/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42762 From https://github.com/nodejs/node * branch refs/pull/42762/merge -> FETCH_HEAD ✔ Fetched commits as 61fefe1959a8..88b6f6a0806b -------------------------------------------------------------------------------- [master 2b513c011a] build: clarify missing clang-format tool Author: Tobias Nießen Date: Sun Apr 17 13:34:31 2022 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- build: clarify missing clang-format tool

Co-authored-by: Rich Trott rtrott@gmail.com

PR-URL: #42762
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[master 7ecf53cfb5] build: clarify missing clang-format tool
Author: Tobias Nießen tniessen@tnie.de
Date: Sun Apr 17 13:34:31 2022 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
✖ 7ecf53cfb5387c10fef9a53953e370ae1683a55d
✖ 1:0 Co-authored-by must be a trailer co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 3:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/2199723145

tniessen · 2022-04-21T12:55:08Z

It's prevented from landing by nodejs/core-validate-commit#93 but the real issue is nodejs/node-core-utils#602 once again.

tniessen · 2022-05-14T22:20:44Z

nodejs/node-core-utils#632 will hopefully resolve the tooling issue.

mhdawson

LGTM

aduh95 · 2022-07-07T20:17:59Z

Landed in e9f69e8

PR-URL: #42762 Co-authored-by: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

PR-URL: nodejs/node#42762 Co-authored-by: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

tniessen requested a review from RaisinTen April 17, 2022 11:36

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Apr 17, 2022

tniessen force-pushed the makefile-clang-format-is-not-clang-format branch from 9fe4a40 to 671b6dc Compare April 17, 2022 11:37

tniessen changed the title ~~build: clarify ḿissing clang-format tool~~ build: clarify missing clang-format tool Apr 17, 2022

tniessen added fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels Apr 17, 2022

RaisinTen approved these changes Apr 17, 2022

View reviewed changes

Trott reviewed Apr 17, 2022

View reviewed changes

Makefile Outdated Show resolved Hide resolved

Trott approved these changes Apr 17, 2022

View reviewed changes

Mesteery approved these changes Apr 17, 2022

View reviewed changes

build: clarify missing clang-format tool

88b6f6a

Co-authored-by: Rich Trott <rtrott@gmail.com>

tniessen force-pushed the makefile-clang-format-is-not-clang-format branch from 4e3628a to 88b6f6a Compare April 17, 2022 20:30

lpinca approved these changes Apr 18, 2022

View reviewed changes

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 18, 2022

tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2022

tniessen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 18, 2022

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 18, 2022

This was referenced Apr 19, 2022

CI Reliability 2022-04-19 nodejs/reliability#256

Open

CI Reliability 2022-04-20 nodejs/reliability#257

Open

jasnell approved these changes Apr 20, 2022

View reviewed changes

github-actions bot mentioned this pull request Apr 21, 2022

CI Reliability 2022-04-21 nodejs/reliability#258

Open

22 tasks

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 21, 2022

This was referenced Apr 22, 2022

CI Reliability 2022-04-22 nodejs/reliability#259

Open

CI Reliability 2022-04-23 nodejs/reliability#260

Open

mhdawson approved these changes May 27, 2022

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 5, 2022

aduh95 merged commit e9f69e8 into nodejs:main Jul 7, 2022

targos mentioned this pull request Jul 12, 2022

v18.6.0 release proposal #43789

Merged

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: clarify missing clang-format tool #42762

build: clarify missing clang-format tool #42762

tniessen commented Apr 17, 2022

github-actions bot commented Apr 17, 2022

nodejs-github-bot commented Apr 18, 2022

tniessen commented Apr 18, 2022

nodejs-github-bot commented Apr 18, 2022

nodejs-github-bot commented Apr 18, 2022

nodejs-github-bot commented Apr 18, 2022

nodejs-github-bot commented Apr 18, 2022

PR-URL: #42762
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

nodejs-github-bot commented Apr 21, 2022

PR-URL: #42762
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

tniessen commented Apr 21, 2022

tniessen commented May 14, 2022

mhdawson left a comment

aduh95 commented Jul 7, 2022

build: clarify missing clang-format tool #42762

build: clarify missing clang-format tool #42762

Conversation

tniessen commented Apr 17, 2022

github-actions bot commented Apr 17, 2022

nodejs-github-bot commented Apr 18, 2022

tniessen commented Apr 18, 2022

nodejs-github-bot commented Apr 18, 2022

nodejs-github-bot commented Apr 18, 2022

nodejs-github-bot commented Apr 18, 2022

nodejs-github-bot commented Apr 18, 2022

PR-URL: #42762 Reviewed-By: Darshan Sen raisinten@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Mestery mestery@protonmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com

nodejs-github-bot commented Apr 21, 2022

PR-URL: #42762 Reviewed-By: Darshan Sen raisinten@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com Reviewed-By: Mestery mestery@protonmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

tniessen commented Apr 21, 2022

tniessen commented May 14, 2022

mhdawson left a comment

Choose a reason for hiding this comment

aduh95 commented Jul 7, 2022

PR-URL: #42762
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #42762
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com