src,crypto: remove uses of AllocatedBuffer from crypto_ec.cc
#42766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com>
|
Review requested:
|
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen
added
the
commit-queue-squash
dygabo
reviewed
Apr 17, 2022
This was referenced Apr 18, 2022
jasnell
approved these changes
Apr 20, 2022
22 tasks
RaisinTen
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Apr 22, 2022
This comment was marked as outdated.
This comment was marked as outdated.
RaisinTen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 709d279 |
RaisinTen
deleted the
src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_ec.cc
branch
16 tasks
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Refs: nodejs#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42766 Reviewed-By: James M Snell <jasnell@gmail.com>
14 tasks
This was referenced Apr 27, 2022
21 tasks
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#42766 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #39941
Signed-off-by: Darshan Sen raisinten@gmail.com