src: remove usage of `AllocatedBuffer` from `src/node_buffer.cc` #39941

RaisinTen · 2021-08-30T08:07:22Z

Since AllocatedBuffer is just a thin wrapper around v8::BackingStore, we
should prefer using v8::BackingStore directly.

Refs:

node/src/allocated_buffer.h

Lines 30 to 31 in 52abf27

    
           // TODO(addaleax): We may want to start phasing this out as it's only a 
        
           // thin wrapper around v8::BackingStore at this point

Signed-off-by: Darshan Sen darshan.sen@postman.com

src/node_buffer.cc

Since AllocatedBuffer is just a thin wrapper around v8::BackingStore, we should prefer using v8::BackingStore directly. Refs: https://github.com/nodejs/node/blob/52abf271c563ddffdc93b444ea05e5347a7f2784/src/allocated_buffer.h#L30-L31 Signed-off-by: Darshan Sen <darshan.sen@postman.com>

nodejs-github-bot · 2021-08-30T09:06:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/39705/ 💛

jasnell · 2021-09-03T14:42:40Z

Landed in 7cc96b2

Since AllocatedBuffer is just a thin wrapper around v8::BackingStore, we should prefer using v8::BackingStore directly. Refs: https://github.com/nodejs/node/blob/52abf271c563ddffdc93b444ea05e5347a7f2784/src/allocated_buffer.h#L30-L31 Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #39941 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: nodejs#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs: #39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42492 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

ZeroPadDiffieHellmanSecret() is in an anonymous namespace, so it has static linkage already. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42492 Refs: #39941 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Buffer::Length() dereferences the passed Local, so calling it when the underlying pointer is a nullptr would lead to a crash. This fixes that by returning early instead. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42492 Refs: #39941 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: nodejs#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com>

Refs: nodejs#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42492 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

ZeroPadDiffieHellmanSecret() is in an anonymous namespace, so it has static linkage already. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42492 Refs: #39941 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Buffer::Length() dereferences the passed Local, so calling it when the underlying pointer is a nullptr would lead to a crash. This fixes that by returning early instead. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42492 Refs: #39941 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: #39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42589 Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: #39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42766 Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: #39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42852 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Since all its uses are now gone, it's time to say goodbye to AllocatedBuffer. Refs: #39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43008 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>