-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: use serial comma in cluster docs #42989
Merged
nodejs-github-bot
merged 1 commit into
nodejs:master
from
tniessen:doc-cluster-oxford-comma
May 6, 2022
Merged
doc: use serial comma in cluster docs #42989
nodejs-github-bot
merged 1 commit into
nodejs:master
from
tniessen:doc-cluster-oxford-comma
May 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast-track has been requested by @tniessen. Please 👍 to approve. |
RaisinTen
approved these changes
May 6, 2022
Trott
approved these changes
May 6, 2022
VoltrexKeyva
approved these changes
May 6, 2022
Landed in 74af116 |
Merged
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#11321 Refs: nodejs/node#17384 PR-URL: nodejs/node#42989 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cluster
Issues and PRs related to the cluster subsystem.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node/doc/README.md
Line 21 in 5e9274a
Refs: #11321
Refs: #17384