Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reduce flakiness of test-fs-read-position-validation.mjs #42999

Merged
merged 9 commits into from May 15, 2022
Merged

test: reduce flakiness of test-fs-read-position-validation.mjs #42999

merged 9 commits into from May 15, 2022

Conversation

LiviaMedeiros
Copy link
Contributor

The said test failed randomly several times with EBADF error code: [1], [2], [3]

This PR should make the test more reliable by promisifying Callback API parts and calling them in sequence.
Additionally, it separates Callback API and Synchronous API parts into two tests, in anticipation of validation in Promises API.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 7, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 9, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 9, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43932/

This was referenced May 14, 2022
Merged
Merged
@LiviaMedeiros LiviaMedeiros force-pushed the fs-reads-position-test-segregate branch from 523f1b9 to 11a5b35 Compare May 15, 2022 08:34
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44015/

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2022
@nodejs-github-bot nodejs-github-bot merged commit e330b45 into nodejs:master May 15, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in e330b45

BethGriggs pushed a commit that referenced this pull request May 16, 2022
@LiviaMedeiros @BethGriggs
test: reduce flakiness of test-fs-read-position-validation.mjs
9eb8bf1 
PR-URL: #42999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@LiviaMedeiros @juanarbol
test: reduce flakiness of test-fs-read-position-validation.mjs
5e3c72a 
PR-URL: #42999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
@richardlau richardlau mentioned this pull request Jun 20, 2022
Merged
nodejs-github-bot pushed a commit that referenced this pull request Jun 22, 2022
@richardlau
test: allow EOVERFLOW errors in fs position tests
3b8f3e6 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: #43510
Refs: #42999
Refs: #43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
F3n67u pushed a commit to F3n67u/node that referenced this pull request Jun 24, 2022
@richardlau @F3n67u
test: allow EOVERFLOW errors in fs position tests
2fd4622 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: nodejs#43510
Refs: nodejs#42999
Refs: nodejs#43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams
Copy link
Member

@LiviaMedeiros this breaks tests when landing in v16.x. Do you mind creating a backport PR to v16.x-staging? Thanks

LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Jun 27, 2022
@LiviaMedeiros
test: reduce flakiness of test-fs-read-position-validation.mjs
c2ca4a5 
PR-URL: nodejs#42999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Jun 27, 2022
@LiviaMedeiros
test: reduce flakiness of test-fs-read-position-validation.mjs
615129f 
PR-URL: nodejs#42999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Jun 27, 2022
@LiviaMedeiros
test: reduce flakiness of test-fs-read-position-validation.mjs
68817e0 
PR-URL: nodejs#42999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@LiviaMedeiros LiviaMedeiros mentioned this pull request Jun 27, 2022
Closed
LiviaMedeiros added a commit to LiviaMedeiros/node that referenced this pull request Jun 27, 2022
@LiviaMedeiros
test: reduce flakiness of test-fs-read-position-validation.mjs
ceee7be 
PR-URL: nodejs#42999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Backport-PR-URL: nodejs#43588
targos pushed a commit that referenced this pull request Jul 12, 2022
@richardlau @targos
test: allow EOVERFLOW errors in fs position tests
7ca58b8 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: #43510
Refs: #42999
Refs: #43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 18, 2022
@LiviaMedeiros @targos
test: reduce flakiness of test-fs-read-position-validation.mjs
9d273d3 
PR-URL: #42999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2022
@richardlau @targos
test: allow EOVERFLOW errors in fs position tests
8e72a2c 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: #43510
Refs: #42999
Refs: #43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@LiviaMedeiros @targos
test: reduce flakiness of test-fs-read-position-validation.mjs
8e5e5a1 
PR-URL: #42999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@richardlau @targos
test: allow EOVERFLOW errors in fs position tests
7ce80d8 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: #43510
Refs: #42999
Refs: #43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@LiviaMedeiros @guangwong
test: reduce flakiness of test-fs-read-position-validation.mjs
613b3fc 
PR-URL: nodejs/node#42999
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@richardlau @guangwong
test: allow EOVERFLOW errors in fs position tests
8089011 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: nodejs/node#43510
Refs: nodejs/node#42999
Refs: nodejs/node#43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LiviaMedeiros @nodejs-github-bot @danielleadams @aduh95 @targos