Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add mailmap entry for npm team #43143

Merged

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 18, 2022

As titled.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 18, 2022
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 18, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@lpinca
Copy link
Member Author

lpinca commented May 18, 2022

I'll move the second commit to a different PR to keep things clean.

@lpinca lpinca force-pushed the add/mailmap-entry-for-npm-teamp branch from d9c276b to 96bcfec Compare May 18, 2022 19:11
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 19, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43143
✔  Done loading data for nodejs/node/pull/43143
----------------------------------- PR info ------------------------------------
Title      meta: add mailmap entry for npm team (#43143)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     lpinca:add/mailmap-entry-for-npm-teamp -> nodejs:master
Labels     meta, fast-track, author ready
Commits    1
 - meta: add mailmap entry for npm team
Committers 1
 - Luigi Pinca 
PR-URL: https://github.com/nodejs/node/pull/43143
Reviewed-By: Rich Trott 
Reviewed-By: Tobias Nießen 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43143
Reviewed-By: Rich Trott 
Reviewed-By: Tobias Nießen 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 18 May 2022 17:54:33 GMT
   ✔  Approvals: 3
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43143#pullrequestreview-977491383
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43143#pullrequestreview-977528970
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43143#pullrequestreview-978043935
   ℹ  This PR is being fast-tracked
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2352029089

Trott pushed a commit that referenced this pull request May 19, 2022
PR-URL: #43143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@Trott Trott closed this May 19, 2022
@Trott Trott reopened this May 19, 2022
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry in this PR will have no affect. It needs to be changed.

.mailmap Outdated Show resolved Hide resolved
@lpinca lpinca force-pushed the add/mailmap-entry-for-npm-teamp branch from b8a2975 to 83a4524 Compare May 19, 2022 13:48
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit f7d55b9 into nodejs:master May 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f7d55b9

@lpinca lpinca deleted the add/mailmap-entry-for-npm-teamp branch May 19, 2022 17:52
bengl pushed a commit that referenced this pull request May 30, 2022
PR-URL: #43143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
ruyadorno pushed a commit that referenced this pull request May 31, 2022
PR-URL: #43143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@bengl bengl mentioned this pull request May 31, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #43143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #43143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43143
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants