net,dns:move hasObserver out of perf function #43217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dns
theanarkh
force-pushed
the
move_hasObserver_out_of_perf_function
branch
from
689ad95
to
7cb6990
Compare
|
@mcollina Hello, can you help review this PR? Thanks ! |
JungMinu
approved these changes
May 31, 2022
theanarkh
force-pushed
the
move_hasObserver_out_of_perf_function
branch
2 times, most recently
from
896bf69
to
18b93f8
Compare
17 tasks
move the hasObserver out of startPerf and stopPerf to avoid generating useless objects when these are no observer
theanarkh
force-pushed
the
move_hasObserver_out_of_perf_function
branch
from
18b93f8
to
42c6e46
Compare
Thanks. can you please help trigger CI ? |
This comment was marked as outdated.
This comment was marked as outdated.
19 tasks
This comment was marked as outdated.
This comment was marked as outdated.
|
@theanarkh I took care of it. Enjoy :) |
Thank you very much 😊. |
19 tasks
RaisinTen
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
21 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
|
|
@RaisinTen @aduh95 @ShogunPanda @mcollina @JungMinu Hi, can you please help merge this PR ? Thanks ! |
That one seems to be passing in the latest CI run - https://ci.nodejs.org/job/node-test-pull-request/44373/, landing now. |
RaisinTen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 85f8821 |
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
move the hasObserver out of startPerf and stopPerf to avoid generating useless objects when these are no observer PR-URL: #43217 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
move the hasObserver out of startPerf and stopPerf to avoid generating useless objects when these are no observer PR-URL: #43217 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
move the hasObserver out of startPerf and stopPerf to avoid generating useless objects when these are no observer PR-URL: #43217 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
move the hasObserver out of startPerf and stopPerf to avoid generating useless objects when these are no observer PR-URL: #43217 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
move the hasObserver out of startPerf and stopPerf to avoid generating useless objects when these are no observer PR-URL: #43217 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
move the hasObserver out of startPerf and stopPerf to avoid generating useless objects when these are no observer PR-URL: nodejs/node#43217 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the
hasObserverout ofstartPerfandstopPerfto avoid generating useless objects when these are no observer.
See #43002
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected subsystem: net,dns