doc: fix chromium document link in pull-requests.md #43265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
tniessen
approved these changes
May 31, 2022
VoltrexKeyva
approved these changes
May 31, 2022
lpinca
approved these changes
May 31, 2022
aduh95
added
the
author ready
Ayase-252
approved these changes
Jun 2, 2022
RaisinTen
approved these changes
Jun 2, 2022
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43265 ✔ Done loading data for nodejs/node/pull/43265 ----------------------------------- PR info ------------------------------------ Title doc: fix chromium document link in pull-requests.md (#43265) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch rikapo:fix/pr-doc-link -> nodejs:master Labels doc, author ready Commits 1 - doc: fix chromium document link in pull-requests.md Committers 1 - rikapo PR-URL: https://github.com/nodejs/node/pull/43265 Reviewed-By: Tobias Nießen Reviewed-By: Michael Dawson Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Qingyu Deng Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43265 Reviewed-By: Tobias Nießen Reviewed-By: Michael Dawson Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Qingyu Deng Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 31 May 2022 17:19:08 GMT ✔ Approvals: 6 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43265#pullrequestreview-990841042 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/43265#pullrequestreview-990878358 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43265#pullrequestreview-990900538 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43265#pullrequestreview-991037698 ✔ - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/43265#pullrequestreview-992881677 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43265#pullrequestreview-992976708 ✖ This PR needs to wait 1 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2429282559 |
tniessen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 218664f |
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 6, 2022
PR-URL: nodejs#43265 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
PR-URL: #43265 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43265 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43265 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43265 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43265 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chromium document link in pull-requests.md was moved.
this PR changes it to the new link.