doc: make clear the result of comparison between Symbol.for #43309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
tniessen
approved these changes
Jun 4, 2022
aduh95
approved these changes
Jun 4, 2022
cjihrig
approved these changes
Jun 4, 2022
aduh95
added
the
author ready
marsonya
approved these changes
Jun 5, 2022
marsonya
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/43309 ✔ Done loading data for nodejs/node/pull/43309 ----------------------------------- PR info ------------------------------------ Title doc: make clear the result of comparison between Symbol.for (#43309) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cola119:make-symbol-doc-clear -> nodejs:master Labels doc, author ready Commits 1 - doc: make clear the result of comparison between Symbol.for Committers 1 - cola119 PR-URL: https://github.com/nodejs/node/pull/43309 Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Matteo Collina Reviewed-By: Akhil Marsonya ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43309 Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Matteo Collina Reviewed-By: Akhil Marsonya -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 04 Jun 2022 00:48:07 GMT ✔ Approvals: 5 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43309#pullrequestreview-995645903 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/43309#pullrequestreview-995792677 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/43309#pullrequestreview-995943669 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43309#pullrequestreview-995984749 ✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/43309#pullrequestreview-996026290 ✖ This PR needs to wait 6 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2443883619 |
nodejs-github-bot
added
the
commit-queue-failed
|
CI failed by |
RaisinTen
approved these changes
Jun 6, 2022
RaisinTen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 18a0ead |
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
PR-URL: #43309 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43309 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43309 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43309 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43309 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43309 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR made clear the execution result of the inline script in the same way as L22 to be able to understand the difference of
Symbol()andSymbol.for()at a glance.node/doc/contributing/using-symbols.md
Lines 20 to 22 in dfa896f