doc: update main branch name in src/README #43442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
lpinca
approved these changes
Jun 16, 2022
richardlau
approved these changes
Jun 16, 2022
panva
added
doc
VoltrexKeyva
approved these changes
Jun 16, 2022
RaisinTen
approved these changes
Jun 16, 2022
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
richardlau
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43442 ✔ Done loading data for nodejs/node/pull/43442 ----------------------------------- PR info ------------------------------------ Title doc: update main branch name in src/README (#43442) Author Feng Yu (@F3n67u) Branch F3n67u:readme/main -> nodejs:main Labels doc, fast-track, author ready Commits 1 - doc: update main branch name in src/README Committers 1 - F3n67u PR-URL: https://github.com/nodejs/node/pull/43442 Refs: https://github.com/nodejs/node/issues/33864 Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43442 Refs: https://github.com/nodejs/node/issues/33864 Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 16 Jun 2022 02:56:06 GMT ✔ Approvals: 4 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43442#pullrequestreview-1008498544 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/43442#pullrequestreview-1008540292 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43442#pullrequestreview-1008814801 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43442#pullrequestreview-1009053997 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2512076678 |
aduh95
approved these changes
Jun 17, 2022
|
Landed in 2887b1b |
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43442 Refs: nodejs/node#33864 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #33864