test: skip test-net-connect-reset-until-connected on SmartOS #43449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
panva
added
the
flaky-test
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Jun 16, 2022
panva
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
|
Nit: marking a test flaky doesn't skip it -- it changes how we treat failures for it. |
I guess the nit is for the commit message then? Shall I update it and re-run CI? |
|
As per #43446 (comment) and #43446 (comment) other tests are also timing out on "smartos20-64". I wonder if it makes sense to restart the machine. |
31 tasks
|
FYI, I'm proposing in #43457 to simply drop smartos support. |
|
@bnoordhuis That's fine, but until then can we unjam CI/PRs by marking this test as flaky? |
|
Fast-track has been requested by @panva. Please 👍 to approve. |
This was referenced Jun 18, 2022
panva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43449 ✔ Done loading data for nodejs/node/pull/43449 ----------------------------------- PR info ------------------------------------ Title test: skip test-net-connect-reset-until-connected on SmartOS (#43449) Author Filip Skokan (@panva) Branch panva:flaky-test-net-connect-reset-until-connected -> nodejs:main Labels test, flaky-test, fast-track, author ready, needs-ci Commits 1 - test: skip test-net-connect-reset-until-connected on SmartOS Committers 1 - Filip Skokan PR-URL: https://github.com/nodejs/node/pull/43449 Refs: https://github.com/nodejs/node/issues/43446 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43449 Refs: https://github.com/nodejs/node/issues/43446 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 16 Jun 2022 09:22:01 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43449#pullrequestreview-1008839474 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-06-16T12:03:05Z: https://ci.nodejs.org/job/node-test-pull-request/44616/ - Querying data for job/node-test-pull-request/44616/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2523244812 |
aduh95
approved these changes
Jun 19, 2022
aduh95
removed
the
commit-queue-failed
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2609dc6 |
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: #43446 PR-URL: nodejs/node#43449 Refs: nodejs/node#43446 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #43446