test_runner: protect internals against prototype tampering #43578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
approved these changes
Jun 26, 2022
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
VoltrexKeyva
approved these changes
Jun 26, 2022
This comment was marked as outdated.
This comment was marked as outdated.
33 tasks
cjihrig
approved these changes
Jun 27, 2022
jasnell
approved these changes
Jun 27, 2022
This was referenced Jun 28, 2022
aduh95
force-pushed
the
test_runner-no-prototype-tampering
branch
from
9d057ae
to
823e3f8
Compare
github-actions
bot
removed
the
request-ci
23 tasks
21 tasks
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43578 ✔ Done loading data for nodejs/node/pull/43578 ----------------------------------- PR info ------------------------------------ Title test_runner: protect internals against prototype tampering (#43578) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:test_runner-no-prototype-tampering -> nodejs:main Labels author ready, needs-ci, test_runner Commits 1 - test_runner: protect internals against prototype tampering Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/43578 Reviewed-By: Tobias Nießen Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Colin Ihrig Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43578 Reviewed-By: Tobias Nießen Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Colin Ihrig Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test_runner: protect internals against prototype tampering ℹ This PR was created on Sun, 26 Jun 2022 12:13:10 GMT ✔ Approvals: 4 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43578#pullrequestreview-1019462805 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43578#pullrequestreview-1019477490 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/43578#pullrequestreview-1019499127 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/43578#pullrequestreview-1020512524 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-07-09T08:38:03Z: https://ci.nodejs.org/job/node-test-pull-request/45200/ - Querying data for job/node-test-pull-request/45200/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2640993170 |
|
Landed in 2fe4e94 |
aduh95
added a commit
to aduh95/node-core-test
that referenced
this pull request
Jul 9, 2022
PR-URL: nodejs/node#43578 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
added a commit
to aduh95/node-core-test
that referenced
this pull request
Jul 9, 2022
PR-URL: nodejs/node#43578 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
20 tasks
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43578 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43578 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43578 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @nodejs/test_runner