doc: remove lttng from tierlist #43604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
bnoordhuis
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
LGTM. For the record: lttng support was removed in 2018 in commit 30fd3d2 and was broken (as in: didn't build) since 2016.
RafaelGSS
approved these changes
Jun 29, 2022
RaisinTen
approved these changes
Jun 29, 2022
Flarna
approved these changes
Jun 29, 2022
Hey make sense. |
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43604 ✔ Done loading data for nodejs/node/pull/43604 ----------------------------------- PR info ------------------------------------ Title doc: remove lttng from tierlist (#43604) Author Tony Gorez (@tony-go) Branch tony-go:remove-lttng-tierlist -> nodejs:main Labels doc Commits 1 - doc: remove lttng from tierlist Committers 1 - Tony Gorez PR-URL: https://github.com/nodejs/node/pull/43604 Reviewed-By: Ben Noordhuis Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen Reviewed-By: Gerhard Stöbich ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43604 Reviewed-By: Ben Noordhuis Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen Reviewed-By: Gerhard Stöbich -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 28 Jun 2022 19:17:30 GMT ✔ Approvals: 4 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023135322 ✔ - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023382545 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023408203 ✔ - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023940228 ✖ This PR needs to wait 7 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2589812099 |
aduh95
added
author ready
lpinca
approved these changes
Jul 1, 2022
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43604 ✔ Done loading data for nodejs/node/pull/43604 ----------------------------------- PR info ------------------------------------ Title doc: remove lttng from tierlist (#43604) Author Tony Gorez (@tony-go) Branch tony-go:remove-lttng-tierlist -> nodejs:main Labels doc, author ready Commits 1 - doc: remove lttng from tierlist Committers 1 - Tony Gorez PR-URL: https://github.com/nodejs/node/pull/43604 Reviewed-By: Ben Noordhuis Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen Reviewed-By: Gerhard Stöbich Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43604 Reviewed-By: Ben Noordhuis Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen Reviewed-By: Gerhard Stöbich Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 28 Jun 2022 19:17:30 GMT ✔ Approvals: 5 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023135322 ✔ - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023382545 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023408203 ✔ - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023940228 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43604#pullrequestreview-1026590298 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 43604 From https://github.com/nodejs/node * branch refs/pull/43604/merge -> FETCH_HEAD ✔ Fetched commits as 2bd940c0cb59..bcafde91ba73 -------------------------------------------------------------------------------- Auto-merging doc/contributing/diagnostic-tooling-support-tiers.md CONFLICT (content): Merge conflict in doc/contributing/diagnostic-tooling-support-tiers.md error: could not apply bcafde91ba... doc: remove lttng from tierlist hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". ✖ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/2598812931 |
|
@tony-go can you resolve conflicts? |
tony-go
force-pushed
the
remove-lttng-tierlist
branch
from
bcafde9
to
52b0dac
Compare
|
Rebased ↪️ |
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/43604 ✔ Done loading data for nodejs/node/pull/43604 ----------------------------------- PR info ------------------------------------ Title doc: remove lttng from tierlist (#43604) Author Tony Gorez (@tony-go) Branch tony-go:remove-lttng-tierlist -> nodejs:main Labels doc, author ready Commits 1 - doc: remove lttng from tierlist Committers 1 - Tony Gorez PR-URL: https://github.com/nodejs/node/pull/43604 Reviewed-By: Ben Noordhuis Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen Reviewed-By: Gerhard Stöbich Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43604 Reviewed-By: Ben Noordhuis Reviewed-By: Rafael Gonzaga Reviewed-By: Darshan Sen Reviewed-By: Gerhard Stöbich Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - doc: remove lttng from tierlist ℹ This PR was created on Tue, 28 Jun 2022 19:17:30 GMT ✔ Approvals: 5 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023135322 ✔ - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023382545 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023408203 ✔ - Gerhard Stöbich (@Flarna): https://github.com/nodejs/node/pull/43604#pullrequestreview-1023940228 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43604#pullrequestreview-1026590298 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2602972466 |
nodejs-github-bot
added
the
commit-queue-failed
lpinca
pushed a commit
that referenced
this pull request
Jul 3, 2022
PR-URL: #43604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 85fb533. |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43604 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
Context
The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.
Updated
In the previous instance, we examined the case of the
LTTngmodule: issue link.As anyone in the instance has an idea about a potential usage in the field, we decided to remove it. As said in the previous PRs, we prefer to have a list that contains fewer items but is trustable.
But in case you have a different opinion, please share your thoughts in this PR 🙏.
Discuss
As usual, feel free to share your thoughts on that and your experience with this tool.
With love ❤️
cc @nodejs/diagnostics