cluster, net: fix listen pipe with readable and writable in cluster

[theanarkh]

fix listen pipe with readable and writable in cluster.

The bug can be triggered by code as follow.

const cluster = require('cluster');
const net = require('net');
const { unlinkSync } = require('fs');

if (cluster.isPrimary) {
    cluster.fork();
} else {
    try {
        unlinkSync('test.sock');
    } catch(e) {}
    net.createServer(() => {}).listen({
        path: 'test.sock',
        readableAll: true,
        writableAll: true,
    });
}

The permissions of test.sock is srwxr-xr-x instead of srwxrwxrwx .

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected subsystem: cluster, net

[nodejs-github-bot]

Review requested:

• @nodejs/net

[ShogunPanda]

You should also update the API docs.
The rest looks fine to me!

[theanarkh]

You should also update the API docs. The rest looks fine to me!

I think it has been described in the docs before ?

readableAll: For IPC servers makes the pipe readable for all users. Default: false
writableAll: For IPC servers makes the pipe writable for all users. Default: false.

And i think it is a bug, not feature.

[ShogunPanda]

Sorry, I missed those somehow.
Approved, LGTM!

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45020/

[theanarkh]

@mcollina @ShogunPanda @lpinca Hi, can you help trigger CI ? Thanks !

[ShogunPanda]

@theanarkh The CI is currently locked down due to upcoming security release.
You will have to wait couple of days!

[theanarkh]

@theanarkh The CI is currently locked down due to upcoming security release. You will have to wait couple of days!

Thanks! can you help trigger CI ?

[ShogunPanda]

Done sir!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45179/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45207/

[theanarkh]

@aduh95 Hi, can you help merge this PR ? Thanks !

[nodejs-github-bot]

Landed in a933a75