-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: fix error message when specifying headerTimeout for createServer #44163
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
nicksia-vgw:fix-incorrect-headertimeout-error-message
Aug 9, 2022
Merged
http: fix error message when specifying headerTimeout for createServer #44163
nodejs-github-bot
merged 1 commit into
nodejs:main
from
nicksia-vgw:fix-incorrect-headertimeout-error-message
Aug 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the message on the error received when calling http.createServer(...) with a header timeout greater than the request timeout is incorrect. The validation requires that the header timeout is lower than the request timeout, but the error message asks for the opposite.
Review requested:
|
ShogunPanda
approved these changes
Aug 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mcollina
approved these changes
Aug 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
lpinca
approved these changes
Aug 7, 2022
11 tasks
tniessen
approved these changes
Aug 8, 2022
ErickWendel
approved these changes
Aug 8, 2022
8 tasks
rickyes
approved these changes
Aug 9, 2022
Landed in b427924 |
This was referenced Aug 10, 2022
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2022
This change fixes the message on the error received when calling http.createServer(...) with a header timeout greater than the request timeout is incorrect. The validation requires that the header timeout is lower than the request timeout, but the error message asks for the opposite. PR-URL: #44163 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Aug 23, 2022
This change fixes the message on the error received when calling http.createServer(...) with a header timeout greater than the request timeout is incorrect. The validation requires that the header timeout is lower than the request timeout, but the error message asks for the opposite. PR-URL: #44163 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
This change fixes the message on the error received when calling http.createServer(...) with a header timeout greater than the request timeout is incorrect. The validation requires that the header timeout is lower than the request timeout, but the error message asks for the opposite. PR-URL: nodejs#44163 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
This change depends on #41263 which is a semver-major PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
http
Issues or PRs related to the http subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a misleading error message provided by the error thrown when creating an http server with a headerTimeout that exceeds the requestTimeout.
Code
Error
The header timeout is actually required to be
<
the request timeout (which is correctly validated), but the error message is wrong - see original snippet below._http_server.js.storeHTTPOptions
(validation code)