Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x] src: split property helpers from node::Environment #44251

Closed
wants to merge 1 commit into from
Closed

[v18.x] src: split property helpers from node::Environment #44251

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

PR-URL: #44056
Refs: #42528
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Feng Yu F3n67u@outlook.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/modules
  • @nodejs/net
  • @nodejs/startup
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Aug 16, 2022
@legendecas
Copy link
Member Author

/cc @danielleadams

@legendecas
Copy link
Member Author

The file that linter is complaining about is not changed in this PR. I'll leave it to releasers to determine what to do with the staging branch.

@danielleadams
Copy link
Member

Hi @legendecas - I had to update v18.x-staging, so this will need a rebase

@legendecas
src: split property helpers from node::Environment
aed3566 
PR-URL: nodejs#44056
Refs: nodejs#42528
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@legendecas
Copy link
Member Author

@danielleadams rebased.

@ruyadorno
Copy link
Member

Landed in 68ee8e9

@ruyadorno ruyadorno closed this Aug 21, 2022
ruyadorno pushed a commit that referenced this pull request Aug 21, 2022
@legendecas @ruyadorno
src: split property helpers from node::Environment
68ee8e9 
PR-URL: #44056
Backport-PR-URL: #44251
Refs: #42528
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@legendecas legendecas deleted the backport-44056-to-18 branch August 22, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@legendecas @nodejs-github-bot @danielleadams @ruyadorno