Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: remove unused global parameter in per-context scripts #44472

Closed
wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Contributor

Review requested:

  • @nodejs/startup

@joyeecheung joyeecheung marked this pull request as ready for review Sep 1, 2022
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 1, 2022
@nodejs-github-bot
Copy link
Contributor

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 3, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 3, 2022
@nodejs-github-bot
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/44472
✔  Done loading data for nodejs/node/pull/44472
----------------------------------- PR info ------------------------------------
Title      bootstrap: remove unused global parameter in per-context scripts (#44472)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:remove-global -> nodejs:main
Labels     c++, author ready, needs-ci
Commits    1
 - bootstrap: remove unused global parameter in per-context scripts
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/44472
Reviewed-By: Chengzhong Wu 
Reviewed-By: Tobias Nießen 
Reviewed-By: Anna Henningsen 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Minwoo Jung 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44472
Reviewed-By: Chengzhong Wu 
Reviewed-By: Tobias Nießen 
Reviewed-By: Anna Henningsen 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Minwoo Jung 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 01 Sep 2022 07:38:28 GMT
   ✔  Approvals: 5
   ✔  - Chengzhong Wu (@legendecas): https://github.com/nodejs/node/pull/44472#pullrequestreview-1092944173
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44472#pullrequestreview-1092954123
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/44472#pullrequestreview-1093124829
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/44472#pullrequestreview-1093152278
   ✔  - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/44472#pullrequestreview-1094185837
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-09-01T07:39:16Z: https://ci.nodejs.org/job/node-test-pull-request/46364/
- Querying data for job/node-test-pull-request/46364/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2983750891

joyeecheung added a commit that referenced this pull request Sep 6, 2022
PR-URL: #44472
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@joyeecheung
Copy link
Member Author

Landed in addb726

@joyeecheung joyeecheung closed this Sep 6, 2022
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
PR-URL: nodejs#44472
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
PR-URL: #44472
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 26, 2022
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
PR-URL: #44472
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@juanarbol juanarbol added the dont-land-on-v16.x PRs that should not land on the v16.x-staging branch and should not be released in v16.x. label Oct 3, 2022
@juanarbol
Copy link
Member

This breaks primordials in the v16.x release line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. dont-land-on-v16.x PRs that should not land on the v16.x-staging branch and should not be released in v16.x. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants