[v18.x] test: skip testing --watch with --import
#44530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
cc @nodejs/releasers @RafaelGSS |
aduh95
changed the title
--watch with --import--watch with --import
github-actions
bot
removed
the
request-ci
RafaelGSS
approved these changes
Sep 6, 2022
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
RafaelGSS
force-pushed
the
v18.x-staging
branch
2 times, most recently
from
d912d2d
to
60191c6
Compare
15 tasks
RafaelGSS
force-pushed
the
v18.x-staging
branch
from
60191c6
to
c0cfb14
Compare
The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed. Refs: nodejs#43652 PR-URL: nodejs#44402 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#44045 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#44366 Fixes: nodejs#40429 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
MoLow
force-pushed
the
backport-watch-mode-test
branch
from
c0326da
to
39bdc8e
Compare
|
closing. will backport the entire |
This was referenced Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.