Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: initialize TextDecoder once for performance #44787

Merged
merged 1 commit into from Oct 10, 2022

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 25, 2022

Instead of creating TextDecoder everytime blob.text() is called, we are now using a previously created decoder.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 25, 2022
@anonrig anonrig changed the title blob: initialize TextDecoder once for performance buffer: initialize TextDecoder once for performance Sep 25, 2022
@anonrig anonrig force-pushed the perf/blob branch 2 times, most recently from b37eaa1 to f31f223 Compare September 25, 2022 17:03
lib/internal/blob.js Outdated Show resolved Hide resolved
targos
targos approved these changes Sep 26, 2022
@targos targos added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Contributor

lib/internal/blob.js Show resolved Hide resolved
lpinca
lpinca approved these changes Sep 30, 2022
jasnell
jasnell approved these changes Oct 2, 2022
aduh95
aduh95 approved these changes Oct 10, 2022
@nodejs-github-bot
Copy link
Contributor

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 10, 2022
@nodejs-github-bot nodejs-github-bot merged commit 76229fc into nodejs:main Oct 10, 2022
52 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in 76229fc

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44787
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants