-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix undici version in changelog #44982
Conversation
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <mdawson@devrus.com>
I think the problem was that since the bot was used to land the PR it squashed the two commits and kept the message from the first one. I'm not sure what we can do to avoid this from happening in the future. I guess in this case it probably should have been tagged so that it would not have been squashed. If anybody has any other suggestions of what we might do to handle this in the future I think this PR is a reasonable place to discuss them. |
Maybe make the tools workflow add |
@Trott since I think you created the action in the first place does that seem reasonable to you? |
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44982 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Landed in 10f93679c531Landed in 10f9367 |
I think so, but I haven't tested that or anything..... |
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44982 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44982 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44982 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44982 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
The last PR to update the undici version in V18 and V16 had two commits. Once to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs. I don't think we can necessarily change the commit message in the commit, but I think having the changelogs indicate the correct version makes sense even without that change. This PR updates the version in the two changelogs. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44982 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
The last PR to update the undici version in V18 and V16 had two commits. One to update to 5.9.1 and one to upodate to 5.10.0. Unfortunately it looks like
when squashed the commit indicates 5.9.1 which was reported as confusing in the changelogs.
I don't think we can necessarily change the commit message in the commit, but I think having the
changelogs indicate the correct version makes sense even without that change.
This PR updates the version in the two changelogs.
Signed-off-by: Michael Dawson mdawson@devrus.com