-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: improve the workflow to test release binaries #45004
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RafaelGSS:doc/improve-binary-test
Oct 15, 2022
Merged
doc: improve the workflow to test release binaries #45004
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RafaelGSS:doc/improve-binary-test
Oct 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
aduh95
reviewed
Oct 14, 2022
9d715ce
to
e0588a6
Compare
aduh95
reviewed
Oct 14, 2022
aduh95
reviewed
Oct 14, 2022
richardlau
reviewed
Oct 14, 2022
e0588a6
to
8d6ab7d
Compare
8d6ab7d
to
e72b5ec
Compare
e72b5ec
to
d5a6619
Compare
aduh95
reviewed
Oct 15, 2022
aduh95
approved these changes
Oct 15, 2022
Trott
approved these changes
Oct 15, 2022
lpinca
approved these changes
Oct 15, 2022
jasnell
approved these changes
Oct 15, 2022
Commit Queue failed- Loading data for nodejs/node/pull/45004 ✔ Done loading data for nodejs/node/pull/45004 ----------------------------------- PR info ------------------------------------ Title doc: improve the workflow to test release binaries (#45004) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:doc/improve-binary-test -> nodejs:main Labels doc, author ready Commits 1 - doc: improve the workflow to test release binaries Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/45004 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45004 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Oct 2022 18:12:45 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143203862 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143215322 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143221315 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45004#pullrequestreview-1143226142 ✖ This PR needs to wait 21 more hours to land ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3257083627 |
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Landed in 7ceb624 |
RafaelGSS
added a commit
that referenced
this pull request
Nov 1, 2022
PR-URL: #45004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
added a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45004 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this workflow we have a better test report.
I'm using it to test the new major (v19) and it only fails 2 tests (the ones I mentioned in the doc). Those failures are expected due to the test itself trusting in some variables not present in the final binary.