-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: revert is_release to 0 #45315
src: revert is_release to 0 #45315
Conversation
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@nodejs/tsc Can we merge this without waiting for CI? It affects all new pull requests. |
+1, we should as it'll cause failures elsewhere without it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1 from me as well to merge |
But of course not with the squash and merge. I assume it will need to be landed manually. |
PR-URL: #45315 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Landed in 7124476 |
PR-URL: nodejs#45315 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #45315 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
It was wrongly committed on the v19.0.1 release.