New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move test file to sequential/ due to timing issues #45722
Open
sonimadhuri
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
sonimadhuri:move_test_to_run_sequentially
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: move test file to sequential/ due to timing issues #45722
sonimadhuri
wants to merge
2
commits into
nodejs:main
from
sonimadhuri:move_test_to_run_sequentially
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Dec 3, 2022
…to_run_sequentially
Trott
added
the
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
label
Dec 3, 2022
Closes: #43465 |
@nodejs/http @nodejs/testing |
Trott
approved these changes
Dec 3, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 3, 2022
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 18, 2023
ShogunPanda
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks!
mcollina
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This was referenced Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving test-http-server-request-timeouts-mixed from tests/parallel to tests/sequential
The flaky test is reproducible when we run
tools/test.py -j96 --repeat=1024 test/parallel/test-http-server-request-timeouts-mixed.js
. I tried tuning the timeouts at which the values are asserted, but they still seem to fail because of timing issues when the system is burdened.As a workaround, I have moved the test to run sequentially(verified it with
tools/test.py -j96 --repeat=128 test/sequential/test-http-server-request-timeouts-mixed.js
)