-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the word 'Class' before incomingmessage in http docs #4589
Conversation
LGTM |
LGTM, but the commit message should be updated per https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
`Server`, `ServerResponse` etc. were marked as classes, this one class was overlooked.
a5c8051
to
e328b21
Compare
updated to add subsystem & check line length |
LGTM, although I'm not sure the backticks in the commit message are necessary |
LGTM, landed in b40aca1. And yeah, we don't usually do backticks in commit messages, no specific reason. I left them out 😉 |
First commit to core for you @Sequoia, as far as I can tell. A small one but even minor doc fixes are always appreciated. Thanks! |
@rvagg the pleasure is all mine! 😸 |
`Server`, `ServerResponse` etc. were marked as classes, this one class was overlooked. PR-URL: nodejs#4589 Fixes: nodejs#4576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Closes #4576