-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix setter of event.cancelBubble
#45986
doc: fix setter of event.cancelBubble
#45986
Conversation
Setter of `event.cancelBubble` needs 1 argument(value). And event.cancelBubble() is working if value is true. But it's not described properly. Refs: https://dom.spec.whatwg.org/#interface-event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cancelBubble
is not a function, it's an attribute. Let's use this PR to fix that.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
You're right. I'm confused for setter. Thank you for correction. |
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 Could you please land this PR because this PR is created 1 week ago? |
Commit Queue failed- Loading data for nodejs/node/pull/45986 ✔ Done loading data for nodejs/node/pull/45986 ----------------------------------- PR info ------------------------------------ Title doc: fix setter of `event.cancelBubble` (#45986) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:221227_revise_setter_cancelbubble -> nodejs:main Labels doc, author ready, eventtarget Commits 4 - doc: fix setter of `event.cancelBubble` - Apply suggestions from code review - Add missed `Type:` to specify data type - Revert change of JSDoc Committers 2 - Deokjin Kim - GitHub PR-URL: https://github.com/nodejs/node/pull/45986 Refs: https://dom.spec.whatwg.org/#interface-event Reviewed-By: Antoine du Hamel Reviewed-By: Anna Henningsen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45986 Refs: https://dom.spec.whatwg.org/#interface-event Reviewed-By: Antoine du Hamel Reviewed-By: Anna Henningsen -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 27 Dec 2022 09:40:07 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45986#pullrequestreview-1232059481 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/45986#pullrequestreview-1239531619 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 45986 From https://github.com/nodejs/node * branch refs/pull/45986/merge -> FETCH_HEAD ✔ Fetched commits as 4788c0d2a02a..31f921ee0e1e -------------------------------------------------------------------------------- Auto-merging doc/api/events.md Auto-merging lib/internal/event_target.js [main e1857dd49d] doc: fix setter of `event.cancelBubble` Author: Deokjin Kim Date: Tue Dec 27 18:29:20 2022 +0900 2 files changed, 6 insertions(+), 4 deletions(-) Auto-merging doc/api/events.md [main 5a015f9058] Apply suggestions from code review Author: Deokjin Kim Date: Wed Dec 28 23:10:59 2022 +0900 1 file changed, 3 insertions(+), 3 deletions(-) Auto-merging doc/api/events.md [main 85dd674059] Add missed `Type:` to specify data type Author: Deokjin Kim Date: Thu Dec 29 07:42:22 2022 +0900 1 file changed, 1 insertion(+), 1 deletion(-) Auto-merging lib/internal/event_target.js [main d5b4a2971d] Revert change of JSDoc Author: Deokjin Kim Date: Thu Dec 29 07:50:01 2022 +0900 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)https://github.com/nodejs/node/actions/runs/3859357483 |
Landed in 57add38 |
Setter of `event.cancelBubble` is a no-op if the value passed to it is not `true`. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: nodejs#45986 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Setter of `event.cancelBubble` is a no-op if the value passed to it is not `true`. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: #45986 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Setter of `event.cancelBubble` is a no-op if the value passed to it is not `true`. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: #45986 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Setter of `event.cancelBubble` is a no-op if the value passed to it is not `true`. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: #45986 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Setter of
event.cancelBubble
needs 1 argument(value). And event.cancelBubble() is working if value is true. But it's not described properly.Refs: https://dom.spec.whatwg.org/#interface-event