-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: abort controller emits error in child process #46072
doc: abort controller emits error in child process #46072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use this PR to make the list compliant with https://learn.microsoft.com/en-us/style-guide/scannable-content/lists
Use a bulleted list for things that have something in common but don’t need to appear in a particular order.
Use a numbered list for sequential items (like a procedure) or prioritized items (like a top 10 list).
Don’t use semicolons, commas, or conjunctions (like and or or) at the end of list items.
Commit Queue failed- Loading data for nodejs/node/pull/46072 FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close at consumeBody (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Response.text (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18) at async Request.json (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:51:18) at async Request.query (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:109:20) at async Request.queryAll (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:136:20) at async Request.gql (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/request.js:66:22) at async PRData.getComments (file:///opt/hostedtoolcache/node/18.12.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21) at async Promise.all (index 2) at async Promise.all (index 1) { type: 'system', errno: 'ERR_STREAM_PREMATURE_CLOSE', code: 'ERR_STREAM_PREMATURE_CLOSE', erroredSysCall: undefined }https://github.com/nodejs/node/actions/runs/3859357483 |
Landed in 40815df |
Fixes: nodejs#46036 PR-URL: nodejs#46072 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fixes: #46036