-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: return correct bit length in KeyObject's asymmetricKeyDetails #46106
Conversation
Review requested:
|
14bf4c3
to
00811fa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
00811fa
to
c4cee3e
Compare
Landed in 021f726 |
PR-URL: nodejs#46106 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #46106 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #46106 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #46106 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
I am trying to understand in what version this is fixed, I cannot find it in release notes. We are experiencing this issue in 18.18.2 |
It was first released in v19.15.0 and backported to v18.x with v18.14.0 |
Thank you @panva , I don't know why it still happens then |
@sigalsMelio Could you please open a new issue with a description and reproduction if possible? |
@tniessen trying to figure out whether it's something I need to resolve with jsonwebtoken |
Our KeyObject details incorrectly ceil bit lengths to the nearest multiple of 8.