Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: print stack trace during environment creation failure #46533

Closed
wants to merge 3 commits into from

Commits on Feb 6, 2023

  1. bootstrap: print stack trace during environment creation failure

    nodejs#45888 took the environment
    creation code out of the scope covered by the v8::TryCatch
    that we use to print early failures during environment creation.
    So e.g. when adding something that would fail in node.js, we get
    
    ```
    node:internal/options:554: Uncaught Error: Should not query options before bootstrapping is done
    ```
    
    This patch restores that by adding another v8::TryCatch for it:
    
    ```
    node:internal/options:20
        ({ options: optionsMap } = getCLIOptions());
                                   ^
    
    Error: Should not query options before bootstrapping is done
        at getCLIOptionsFromBinding (node:internal/options:20:32)
        at getOptionValue (node:internal/options:45:19)
        at node:internal/bootstrap/node:433:29
    ```
    joyeecheung committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    5910278 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Configuration menu
    Copy the full SHA
    5547a2e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. fixup! bootstrap: print stack trace during environment creation failure

    Co-authored-by: Anna Henningsen <github@addaleax.net>
    joyeecheung and addaleax committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    544b103 View commit details
    Browse the repository at this point in the history