-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix IPv6 checks on IBM i #46546
Conversation
Failed to start CI- Validating Jenkins credentials ✖ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4127678728 |
@abmusse Can you rebase this to fix the conflict? |
9b4f649
to
6871813
Compare
@richardlau |
FWIW I ran an IBM i CI build for this: |
Good catch @richardlau I need to apply the same errno 42 check in that file as well! else if (common.isIBMi) {
// IBMi returns EUNATCH (ERRNO 42) when IPv6 is disabled
// keep this errno assertion until EUNATCH is recognized by libuv
assert.strictEqual(error.errno, -42);
} Update added fix in |
CI: https://ci.nodejs.org/job/node-test-pull-request/49892/ |
Landed in c2c61e0 |
This is not landing cleanly on v18.x |
@juanarbol This hasn't gone out in a current release yet so it's too early to be considered for v18.x. |
PR-URL: #46546 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
When IPv6 is disabled IBM i returns EUNATCH (errno 42). For now, I've added an errno check in test case. libuv needs to get updated to handle EUNATCH so that the error code can be addressed as EUNATCH. This change is related to changes done in nodejs#46546 At the time this test case (test-net-autoselectfamily-commandline-option) was not enabled
When IPv6 is disabled IBM i returns EUNATCH (errno 42). For now, I've added an errno check in test case. libuv needs to get updated to handle EUNATCH so that the error code can be addressed as EUNATCH. This change is related to changes done in nodejs#46546 At the time this test case (test-net-autoselectfamily-commandline-option) was not enabled
When IPv6 is disabled IBM i returns EUNATCH (errno 42). For now, I've added an errno check in test case. libuv needs to get updated to handle EUNATCH so that the error code can be addressed as EUNATCH. This change is related to changes done in nodejs#46546 At the time this test case was not enabled
When IPv6 is disabled IBM i returns EUNATCH (errno 42) instead of EADDRNOTAVAIL. libuv 1.46.0 adds EUNATCH errno We can now use error.code to refer to EUNATCH in node versions that use libuv 1.46.0. PR-URL: #48050 Refs: #48049 Refs: #46546 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
When IPv6 is disabled IBM i returns EUNATCH (errno 42) instead of EADDRNOTAVAIL. libuv 1.46.0 adds EUNATCH errno We can now use error.code to refer to EUNATCH in node versions that use libuv 1.46.0. PR-URL: #48050 Refs: #48049 Refs: #46546 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
When IPv6 is disabled IBM i returns EUNATCH (errno 42) instead of EADDRNOTAVAIL. libuv 1.46.0 adds EUNATCH errno We can now use error.code to refer to EUNATCH in node versions that use libuv 1.46.0. PR-URL: nodejs#48050 Refs: nodejs#48049 Refs: nodejs#46546 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #46546 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs/node#46546 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs/node#46546 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This fix should help resolve some test failures:
That fail with:
The issues I discovered were 2 fold:
The
hasIPv6
function cannot determine IPv6 on IBM i. The loop back interface on IBM i is named*LOOPBACK
.When IPv6 is disabled IBM i returns EUNATCH (errno 42). For now, I've added an errno check in test case for. I believe that libuv needs to get updated to handle EUNATCH so that the error code can be addressed as
EUNATCH
. Similar to include: add EOVERFLOW status code mapping libuv/libuv#3145CC @nodejs/platform-ibmi
CC @richardlau