Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix test runner examples #46565

Merged

Conversation

richiemccoll
Copy link
Contributor

The current beforeEach and afterEach examples for describe throw errors because t.diagnostic does not exist.

This PR updates those two examples to use the same pattern as before and after which is to use console.log.

Screenshot 2023-02-08 at 13 25 42

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v14.x test_runner Issues and PRs related to the test runner subsystem. labels Feb 8, 2023
@cjihrig
Copy link
Contributor

cjihrig commented Feb 8, 2023

@richiemccoll did you mean to mark this as a draft?

@richiemccoll richiemccoll marked this pull request as ready for review February 8, 2023 14:35
@richiemccoll
Copy link
Contributor Author

@cjihrig I've marked it ready for review now.

@MoLow MoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 8, 2023
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit be49214 into nodejs:main Feb 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in be49214

MylesBorins pushed a commit that referenced this pull request Feb 18, 2023
PR-URL: #46565
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 19, 2023
juliangruber pushed a commit to nodejs/node-core-test that referenced this pull request Mar 16, 2023
PR-URL: nodejs/node#46565
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
(cherry picked from commit be4921474671fb15f0e62adfe2f37253d07eca02)
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46565
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants