os: improve network interface performance #46598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
BridgeAR
force-pushed
the
improve-network-interface-performance
branch
from
2a41858
to
baf5b0d
Compare
mscdex
reviewed
Feb 10, 2023
aduh95
approved these changes
Feb 10, 2023
bnoordhuis
reviewed
Feb 10, 2023
This reduces the overhead of getCIDR() to a minimum. No array is allocated anymore and parts are directly sliced out of the netmask string instead. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
force-pushed
the
improve-network-interface-performance
branch
from
baf5b0d
to
bc967fa
Compare
BridgeAR
added
author ready
github-actions
bot
removed
the
request-ci
BridgeAR
added
the
author ready
32 tasks
BridgeAR
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46598 ✔ Done loading data for nodejs/node/pull/46598 ----------------------------------- PR info ------------------------------------ Title os: improve network interface performance (#46598) Author Ruben Bridgewater (@BridgeAR) Branch BridgeAR:improve-network-interface-performance -> nodejs:main Labels os, author ready, needs-ci Commits 1 - os: improve network interface performance Committers 1 - Ruben Bridgewater PR-URL: https://github.com/nodejs/node/pull/46598 Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46598 Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - os: improve network interface performance ℹ This PR was created on Fri, 10 Feb 2023 02:29:09 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46598#pullrequestreview-1292768411 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-02-17T19:34:06Z: https://ci.nodejs.org/job/node-test-pull-request/49655/ - Querying data for job/node-test-pull-request/49655/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4209174794 |
21 tasks
jasnell
approved these changes
Feb 20, 2023
BridgeAR
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f17a642 |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
This reduces the overhead of getCIDR() to a minimum. No array is allocated anymore and parts are directly sliced out of the netmask string instead. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #46598 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
This reduces the overhead of getCIDR() to a minimum. No array is allocated anymore and parts are directly sliced out of the netmask string instead. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #46598 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the overhead of getCIDR() to a minimum. No array is allocated anymore and parts are directly sliced out of the netmask string instead.
Signed-off-by: Ruben Bridgewater ruben@bridgewater.de