src: allow preventing debug signal handler start #46681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Feb 16, 2023
jasnell
approved these changes
Feb 20, 2023
aduh95
force-pushed
the
optional-debug-handler
branch
from
1b2bfa0
to
79b65fb
Compare
aduh95
added
the
author ready
|
Landed in 56b3162 |
targos
pushed a commit
that referenced
this pull request
May 12, 2024
PR-URL: #46681 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
lukins-cz
pushed a commit
to lukins-cz/OS-Aplet-node
that referenced
this pull request
Jun 1, 2024
PR-URL: nodejs#46681 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electron in some cases does not want to allow certain processes to start the debug signal handler. Example usage is here.
We allow users to decide whether the
--inspect,--inspect-brk, etc. flags are respected or not. When they choose this, we also ensure that SIGUSR1 signal does not initialize the main process inspector. This would allow us to remove a patch we currently float.