node-api: verify cleanup hooks order #46692
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
added
test
cjihrig
approved these changes
Feb 17, 2023
jasnell
approved these changes
Feb 20, 2023
github-actions
bot
removed
the
request-ci
This was referenced Feb 21, 2023
18 tasks
|
It seems like the test is only failing on the alpine build. I'll take a look at it. |
This was referenced Mar 4, 2023
github-actions
bot
added
request-ci-failed
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Starting PR CI job ✘ Failed to start PR CI: 403 Forbiddenhttps://github.com/nodejs/node/actions/runs/4376492148 |
Cleanup hooks are called before the environment shutdown finalizer invocations.
legendecas
force-pushed
the
node-api/cleanup-order
branch
from
3dd11d2
to
2f01895
Compare
aduh95
added
request-ci
22 tasks
github-actions
bot
removed
the
request-ci
This was referenced Mar 11, 2023
github-actions
bot
removed
the
request-ci
20 tasks
24 tasks
legendecas
added a commit
that referenced
this pull request
Mar 14, 2023
Cleanup hooks are called before the environment shutdown finalizer invocations. PR-URL: #46692 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
|
Landed in b80ab31 |
This was referenced Mar 15, 2023
targos
pushed a commit
that referenced
this pull request
Mar 18, 2023
Cleanup hooks are called before the environment shutdown finalizer invocations. PR-URL: #46692 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
19 tasks
This was referenced Apr 3, 2023
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Cleanup hooks are called before the environment shutdown finalizer invocations. PR-URL: #46692 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup hooks are called before the environment shutdown finalizer
invocations.
/cc @nodejs/node-api