Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: remove AUTHORS file #46845

Merged
merged 1 commit into from
Feb 28, 2023
Merged

meta: remove AUTHORS file #46845

merged 1 commit into from
Feb 28, 2023

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 26, 2023

The AUTHORS file does not serve any significant practical purpose and is a bit of a maintenance annoyance. Let's remove it.

@Trott
meta: remove AUTHORS file
9b2e2c4 
The AUTHORS file does not serve any significant practical purpose and is
a bit of a maintenance annoyance. Let's remove it.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Feb 26, 2023
@Trott
Copy link
Member Author

Trott commented Feb 26, 2023

A modest proposal.....

@aduh95
Copy link
Contributor

aduh95 commented Feb 26, 2023

A reason to keep it would be that it seems to help keeping the mailmap up-to-date, which is convenient (but is that worth the maintenance burden? I'm not sure, happy to leave that decision to others).

@Trott Trott marked this pull request as ready for review February 26, 2023 18:29
@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 26, 2023
mcollina
mcollina approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@nodejs-github-bot nodejs-github-bot merged commit a76cb23 into nodejs:main Feb 28, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in a76cb23

@Trott Trott deleted the rm-authors branch March 1, 2023 01:06
targos pushed a commit that referenced this pull request Mar 13, 2023
@Trott @targos
meta: remove AUTHORS file
8934044 
The AUTHORS file does not serve any significant practical purpose and is
a bit of a maintenance annoyance. Let's remove it.

PR-URL: #46845
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@Trott @targos
meta: remove AUTHORS file
b199acd 
The AUTHORS file does not serve any significant practical purpose and is
a bit of a maintenance annoyance. Let's remove it.

PR-URL: #46845
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Mar 14, 2023
Merged
Closed
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@Trott @danielleadams
meta: remove AUTHORS file
abe1488 
The AUTHORS file does not serve any significant practical purpose and is
a bit of a maintenance annoyance. Let's remove it.

PR-URL: #46845
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
blair added a commit to macports/macports-ports that referenced this pull request Apr 13, 2023
@blair
nodejs18: update to version 18.16.0
5346215 
Do not install AUTHORS as it was removed upstream [1][2].

[1] nodejs/node#46845
[2] nodejs/node@abe1488f86
@marco-ippolito marco-ippolito mentioned this pull request May 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@mcollina mcollina mcollina approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@bnb bnb bnb approved these changes

@Linkgoron Linkgoron Linkgoron approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@ronag ronag ronag approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@trivikr trivikr trivikr approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet