Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused v8::Uint32Array from encoding #47003

Merged
merged 1 commit into from
Mar 8, 2023
Merged

src: remove unused v8::Uint32Array from encoding #47003

merged 1 commit into from
Mar 8, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Mar 7, 2023 •
edited

Introduced by commit e5933c8, this pull request removes the unused include which causes cpp linting error.

cc @joyeecheung

@anonrig anonrig requested a review from joyeecheung March 7, 2023 22:10
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 7, 2023
@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2023
RafaelGSS
RafaelGSS approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green ci

joyeecheung
joyeecheung approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it!

(hmm, weird, somehow the fixup was only partially applied by git? 🤯 )

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50264/

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 7, 2023
@cjihrig cjihrig mentioned this pull request Mar 8, 2023
Closed
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit f94ef7c into nodejs:main Mar 8, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f94ef7c

@anonrig anonrig deleted the fix-unused-lint branch March 8, 2023 02:11
targos pushed a commit that referenced this pull request Mar 13, 2023
@anonrig @targos
src: remove unused v8::Uint32Array from encoding
cf73cf8 
PR-URL: #47003
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@anonrig @targos
src: remove unused v8::Uint32Array from encoding
9e65996 
PR-URL: #47003
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@danielleadams danielleadams added the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@anonrig @nodejs-github-bot @Qard @Trott @cjihrig @joyeecheung @richardlau @RafaelGSS @danielleadams @MoLow